Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation test not properly guarded #3460

Closed
RudolfWeeber opened this issue Feb 6, 2020 · 1 comment · Fixed by #3461
Closed

Rotation test not properly guarded #3460

RudolfWeeber opened this issue Feb 6, 2020 · 1 comment · Fixed by #3461
Assignees
@jngrad

Comments

@RudolfWeeber
Copy link
Contributor 

Traceback (most recent call last):
File "/home/weeber/es-builds/wa/testsuite/python/rotation.py", line 46, in test_raise_if_improper 
matrix = self.rotation.as_matrix() AttributeError: 'Rotation' object has no attribute 'as_matrix'

with SciPy version 1.3.3
@jngrad jngrad self-assigned this Feb 6, 2020
@jngrad
Copy link
Member

jngrad commented Feb 6, 2020

I've already fixed it in a branch

@jngrad jngrad mentioned this issue Feb 6, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #3461 Feb 7, 2020
kodiakhq bot added a commit that referenced this issue Feb 7, 2020
@kodiakhq
Refactor thermostats: RNG and code duplication (#3461)
b6b9187 
Description of changes:
- make thermostats fully object-oriented
- convert DPD and thermalized bond to `BaseThermostat`
- centralize their interface in `thermostat.hpp`
- refactor the random number generators using templates
- guard scipy in the testsuite (fixes #3460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jngrad jngrad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor thermostats: RNG and code duplication jngrad/espresso
3 participants
@RudolfWeeber @KaiSzuttor @jngrad