Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out_direction and membrane_collision can be removed #3416

Closed
RudolfWeeber opened this issue Jan 17, 2020 · 0 comments · Fixed by #3418
Closed

Out_direction and membrane_collision can be removed #3416

RudolfWeeber opened this issue Jan 17, 2020 · 0 comments · Fixed by #3418
Assignees
@fweik
Labels
Core

Comments

@RudolfWeeber
Copy link
Contributor

based on Skype discussions with the OIF team, a fix for #2214 has been merged into their code. The fix is too invasive for the main line of Es, though.
Therefore, we'll remove the not-fixed out_direction and membrane_collision from the dev branch.
We will then bring the functionallity back via virtual sites placed at the center of each surface triangle.
@fweik fweik self-assigned this Jan 17, 2020
@fweik fweik added the Core label Jan 17, 2020
@fweik fweik mentioned this issue Jan 17, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #3418 Jan 20, 2020
kodiakhq bot added a commit that referenced this issue Jan 20, 2020
@kodiakhq
core: Removed MEMBRANE_COLLISION + out_direction (#3418)
4bf0f3c 
Fixes #2214. Fixes #3416.

Description of changes:
 - Removed `membrane collision`
 - Removed `out_direction`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fweik fweik

Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: Removed MEMBRANE_COLLISION + out_direction
2 participants
@RudolfWeeber @fweik