Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ComForce observable should be renamed to TotalForce #3370

Closed
RudolfWeeber opened this issue Dec 9, 2019 · 3 comments · Fixed by #3471
Closed

The ComForce observable should be renamed to TotalForce #3370

RudolfWeeber opened this issue Dec 9, 2019 · 3 comments · Fixed by #3471
Assignees

Comments

@RudolfWeeber
Copy link
Contributor

at least that's what the documentation claims it calculates. That's also what would make sense, physically, I think.
The code currenlty calculates
sum F_i m_i
and doesn't normalize by sum_i m_i. I don't think, that makes sense.

@fweik
Copy link
Contributor

fweik commented Dec 10, 2019

If you rename it, it should be called TotalForce, which is a more common term (think total charge, total current, total momentum, ...).

@RudolfWeeber
Copy link
Contributor Author

locations to work on:
/src/core/observables
src/script_interface/observables (including intialize.cppp)
src/python/espressomd/observable.py

@pkreissl
Copy link
Contributor

I'll work on this one.

@jngrad jngrad changed the title The ComForce observable should be renamed to AggregatedForce The ComForce observable should be renamed to TotalForce Feb 11, 2020
@kodiakhq kodiakhq bot closed this as completed in #3471 Feb 11, 2020
kodiakhq bot added a commit that referenced this issue Feb 11, 2020
@jngrad jngrad added this to the Espresso 4.2 milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants