Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump required cmake version to 3.10 #3090

Closed
RudolfWeeber opened this issue Aug 21, 2019 · 3 comments · Fixed by #3375
Closed

Bump required cmake version to 3.10 #3090

RudolfWeeber opened this issue Aug 21, 2019 · 3 comments · Fixed by #3375
Milestone
Espresso 4.2.0

Comments

@RudolfWeeber
Copy link
Contributor

Cmkae fails for 3.8 and older.
@RudolfWeeber
Copy link
Contributor Author

Ubuntu 16.4 has 3.9.2, which seems to work. So using that. PR is forthcoming

@jngrad
Copy link
Member

jngrad commented Aug 21, 2019

This means we can replace if(NOT ${CMAKE_VERSION} VERSION_LESS "3.12") by the more readable if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.12") and remove the checks for 3.5.2 and 3.7.0.

@RudolfWeeber
Copy link
Contributor Author

OK. It's more complicated. Travis uses 3.9.2 on its runners. Ubuntu 16.4 has 3.5.
It's not clear to me under what conditions older cmake versions work.
I'm not going to work on this for 4.1

@jngrad jngrad mentioned this issue Sep 26, 2019
Closed
@jngrad jngrad added this to the Espresso 4.2 milestone Dec 11, 2019
@jngrad jngrad mentioned this issue Dec 11, 2019
Merged
@kodiakhq kodiakhq bot closed this as completed in #3375 Jan 3, 2020
kodiakhq bot added a commit that referenced this issue Jan 3, 2020
@kodiakhq
Update requirements (#3375)
7dbb510 
Increase requirements of CMake, boost, Cython and Python, as discussed in [es meeting 2019-11-26](https://github.com/espressomd/espresso/wiki/Espresso-meeting-2019-11-26).

Closes #3090, Partial fix for #3093

Depends on espressomd/docker#149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging a pull request may close this issue.

Update requirements jngrad/espresso
2 participants
@RudolfWeeber @jngrad