-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1521] use idf tools export to get env vars #1343
Conversation
Download the artifacts for this pull request: |
I installed the extension and I keep getting error when attempting to build the example project. |
I have updated the PR with changes to fix this issue. Please take a look again @Fabricio-ESP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would have liked if the ESP-IDF version would return the entire version, but I see this is what is being returned by the "export" command. I've tested it with esp idf "5.3.1" version and the version I see in doctor command is "5.3"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working on Windows and Linux, running IDF 5.0, 5.3 and 5.4
Description
Use
idf_tools.py export --format key-value
to get ESP-IDF variables required in environment variables.This should fix missing
ESP_IDF_VERSION
from extension tasks and use PATH from idf_tools.py (which is already done but could replace extension implementation.)Type of change
Please delete options that are not relevant.
Steps to test this pull request
Probably the best way to verify that variables are present is to open
ESP-IDF: Open ESP-IDF Terminal
and doecho $ESP_IDF_VERSION
or other environment variable fromidf_tools.py export
output.You can also test with any command like
ESP-IDF: Build your project
but harder to see if variables are available.All variables from
idf_tools.py export --format key-value
should be available in extension commands likeESP-IDF: Open ESP-IDF Terminal
Test Configuration:
Checklist