-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter serial devices by default and allow user to disable chip id in serial port list #1276
Conversation
Download the artifacts for this pull request: |
Pull request has been marked as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @Fabricio-ESP, Please take a look |
Having some troubles to get the correct data from the connected USB devices. Enabling filter, it shows the WROVER module only, the devices using Silicon Labs USB converters are filtered out. Selecting the option to detect the chip id does not change this behavior. Also observed that when the option to read the chip ID is selected, the detection of the WROVER module is intermitent. |
I've added USB CDC-ACM in the default list. Could you try again @Fabricio-ESP ? Regarding the intermittent issue, do you see any related error in the extension log/ doctor command output ? It might be also be a timeout or connection issue. |
126c810
to
e068583
Compare
Confirmed USB devices are not properly selected and filtered. The parameters to filter the devices is disabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues observed on the last build.
Description
Add
idf.enableSerialPortChipIdRequest
andidf.useSerialPortVendorProductFilter
which are set true by default.Now the serial ports listed with the ESP-IDF: Select port to use command will only show know USB serial ports by filtering them with productID and vendorID. This can be disabled with
"idf.useSerialPortVendorProductFilter": false
in settings.jsonesptool.py chip_id is executed when running the previous command to get the chip name and show it in the list. This can be disabled with
"idf.enableSerialPortChipIdRequest": false
in settings.json.Add
idf.usbSerialPortFilters
for user to define the list of USB PID VID filters.Fixes #1274
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
"idf.useSerialPortVendorProductFilter": false
and Click on "ESP-IDF: Select port to use ". Now all serial ports will be shown. If set true, the behavior is back as step 1."idf.enableSerialPortChipIdRequest": false
and Click on "ESP-IDF: Select port to use ". Now the esptool.py chip_id is not executed and the chip name is not shown in list. If set true, the behavior is same as step 1.Expected behaviour:
Expected output:
How has this been tested?
Manual testing with steps above.
Test Configuration:
Checklist