add esp32 p4 stub and target code #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
PTAL @RushikeshPatange |
adwait-esp
approved these changes
Jul 12, 2024
|
LGTM |
adwait-esp
reviewed
Jul 12, 2024
src/esploader.ts
Outdated
| @@ -155,8 +155,7 @@ async function magic2Chip(magic: number): Promise<ROM | null> { | |||
| const { ESP8266ROM } = await import("./targets/esp8266.js"); | |||
| return new ESP8266ROM(); | |||
| } | |||
| case 0x0addbad0: | |||
| case 0x0: { | |||
There was a problem hiding this comment.
The previous change seemed right - Magic value for p4 chip seems to be - 0x0addbad0
There was a problem hiding this comment.
Adding them now
There was a problem hiding this comment.
@adwait-esp which chip revision do you have? (You can check using esptool.py)
There was a problem hiding this comment.
Those values are listed in current esptool master. I've tested with Function EV Board but magic value was 0x7039ad9
adwait-esp
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESP32 P4 support.
Test steps:
Open a browser and go to
http://localhost:1234to launch esptool-js website.