-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ESP-Insights component for esp32 target #99
Conversation
@@ -98,7 +98,7 @@ | |||
}, | |||
{ | |||
"target": "esp32", | |||
"features":["qio_ram"], | |||
"features":["qio_ram","insights"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this would only work on ESP32?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have only added to esp32 target, since It is the only target I have tested, but I guess there won't be a problem to add it for the other SoC series. Should I create another PR for them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you add it to the others, we can accommodate the change in the next 2.0.6 release. Plus we would not need to limit the example to ESP32 only. Keep in mind that ESP32 support is already in Arduino master, so make sure you get it to worm in Arduino as well (there are some errors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until the last days (296fda5#diff-7dc73c61faafeb3cfa84a00d17773425a77c0140f34d8248f8085b82c4dc97a3), the bootloader was created for every flash memory type and so on but now only the elf files are copied to arduino-esp32. Do you know where could I find now the bootloader used while compiling using PlatformIO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for platformio is coming. Necessary changes are already merged in Arduino master, so I guess you will have the full support soon on PIO side as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I will check what are those changes regarding the bootloader generation, this ESP-Insights feature requires also running the esptool with --elf-sha256-offset flag and I made another PR to platformio/platform-espressif32#973 but it seems that it is not yet so clear if this will affect too the bootloader flash flags...
Thank you @me-no-dev!
A running example using a precompiled arduino-esp32 branch using this PR changes can be found here:
https://github.com/paclema/platformio_projects/tree/main/ESP_Insights