Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cron jobs and move libs to releases #187

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

lucasssvaz
Copy link
Contributor

@lucasssvaz lucasssvaz commented Jun 26, 2024

Split the cron job using a matrix with preparations for release/v5.3

@me-no-dev
Copy link
Member

Have a look at this file which should run in the first job to determine if the cron should even run. Yaml code for it was commented in the cron workflow

@lucasssvaz
Copy link
Contributor Author

@me-no-dev
Copy link
Member

it's the same thing in general, but what I point you to would be done before IDF is pulled and uses GITHUB API, instead of git, so it will happen sooner and faster

@lucasssvaz lucasssvaz force-pushed the ci/cron_optimization branch 5 times, most recently from cb4d8cb to 8a9ae64 Compare July 2, 2024 04:06
@lucasssvaz lucasssvaz marked this pull request as ready for review July 2, 2024 04:06
@lucasssvaz
Copy link
Contributor Author

@me-no-dev PTAL if the libs generated here looks fine. Ill also open a PR with some changes to the IDF4 branch here so we can manually trigger it if needed.

Also, we might not be able to use environment variables in the manifest as it is not allowed by the IDF registry. Do you have any other ideas on how to do what we discussed ?

@me-no-dev
Copy link
Member

Do you have any other ideas on how to do what we discussed ?

I suggest you ask in MM if there is any other way. That was the only thing I heard

@lucasssvaz
Copy link
Contributor Author

@me-no-dev PTAL if the generated libs look correct. Specially the package JSON file.
https://github.com/lucasssvaz/esp32-arduino-lib-builder/actions/runs/9786603646

@me-no-dev
Copy link
Member

json looks good

@me-no-dev
Copy link
Member

most of the things we discussed are yet to be implemented :)

@lucasssvaz lucasssvaz changed the title Split cron jobs using matrix Split cron jobs and move libs to releases Jul 17, 2024
@lucasssvaz
Copy link
Contributor Author

lucasssvaz commented Jul 17, 2024

@me-no-dev me-no-dev merged commit 65e6fb1 into espressif:master Aug 19, 2024
8 checks passed
@lucasssvaz lucasssvaz deleted the ci/cron_optimization branch August 19, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants