-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split cron jobs and move libs to releases #187
Conversation
Have a look at this file which should run in the first job to determine if the cron should even run. Yaml code for it was commented in the cron workflow |
Isnt this already being done here ? https://github.com/espressif/esp32-arduino-lib-builder/blob/master/tools/install-esp-idf.sh#L54-L97 |
it's the same thing in general, but what I point you to would be done before IDF is pulled and uses GITHUB API, instead of git, so it will happen sooner and faster |
cb4d8cb
to
8a9ae64
Compare
@me-no-dev PTAL if the libs generated here looks fine. Ill also open a PR with some changes to the IDF4 branch here so we can manually trigger it if needed. Also, we might not be able to use environment variables in the manifest as it is not allowed by the IDF registry. Do you have any other ideas on how to do what we discussed ? |
I suggest you ask in MM if there is any other way. That was the only thing I heard |
8a9ae64
to
6f6313f
Compare
6f6313f
to
18e877b
Compare
@me-no-dev PTAL if the generated libs look correct. Specially the package JSON file. |
json looks good |
most of the things we discussed are yet to be implemented :) |
26ff50a
to
6d86a0b
Compare
@me-no-dev Moved to using releases. Tests in my forks appear to be working as expected https://github.com/lucasssvaz/esp32-arduino-lib-builder/actions/runs/9966497424/job/27539203528 BTW, should we use |
Split the cron job using a matrix with preparations for release/v5.3