Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-lfs to docker container (IDFGH-8060) #9563

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

tpambor
Copy link
Contributor

@tpambor tpambor commented Aug 16, 2022

I propose to add git-lfs to the docker container to support pulling git repositories and submodules which use Git LFS.

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2022

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 16, 2022
@github-actions github-actions bot changed the title Add git-lfs to docker container Add git-lfs to docker container (IDFGH-8060) Aug 16, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@dobairoland
Copy link
Collaborator

Hi @tpambor. Could you please explain the use case where this could be useful? There are many users of this image who are very unhappy by adding anything to these images.

Git is there for cloning and later describing tags. However, I don't see why git-lfs could be useful there.

  1. If you adding anything else into the image then the proper way could be to have a custom one for your need deduced from the esp-idf one.
  2. The image is used with projects outside the image. Therefore, you can set it up there everything locally using your local installation of Git LFS without the need to adding it into the esp-idf image.

@tpambor
Copy link
Contributor Author

tpambor commented Aug 16, 2022

Hi @dobairoland,

I got a component which is stored in a repository which uses Git LFS. The IDF Component Manger clones it as part of the build process but due to the lack of git-lfs only the placeholder files are checked out and not the files stored with LFS.

@dobairoland
Copy link
Collaborator

dobairoland commented Aug 16, 2022

Oh, thanks. That makes sense.

@dobairoland
Copy link
Collaborator

sha=dba5ff8b3abbdb77def2caa106f91403b76b05a2

@dobairoland dobairoland added the PR-Sync-Merge Pull request sync as merge commit label Aug 16, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Aug 16, 2022
@espressif-bot espressif-bot merged commit 4533004 into espressif:master Aug 17, 2022
@tpambor
Copy link
Contributor Author

tpambor commented Aug 18, 2022

@dobairoland

Could this also be backported to v4.4 and v5.0 branch?

@dobairoland
Copy link
Collaborator

Could this also be backported to v4.4 and v5.0 branch?

Yes, I'll attempt to do so. It is blocked by another issue but we are working on it....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants