driver(spi): fix flag check in bus initialization (IDFGH-7574) #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current flag check in the SPI bus initialization is wrong and causes exceptions when using certain SPI hosts in quad transfert mode.
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
sha=3397cf465d60ddb9806838ebeba57b826fa20fdc |
espressif-bot
added
Resolution: NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current flag check in the SPI bus initialization is wrong and causes exceptions when using certain SPI hosts in quad transfert mode.
If the SPI host only supports quad mode and not octal mode (which is the case on the SPI3 host of the ESP32-S3) then we unnecessarily initialize the data4-7 pins which causes an exception.
This check ensures that we only initialize the data4-7 pins if we are in octal mode.