Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb_serial_jtag: make CONFIG_DEFAULT initializer match order of structure definition (IDFGH-7218) #8812

Conversation

davidzuhn
Copy link
Contributor

No description provided.

@davidzuhn
Copy link
Contributor Author

Without this, compiling with C++ throws an error because the order of initialization does not match the order in the structure definition.

In file included from /Users/zoo/esp32/programs/console-advanced-cplusplus/main/console_example_main.cpp:23:
/Users/zoo/esp32/programs/console-advanced-cplusplus/main/console_example_main.cpp: In function 'void initialize_console()':
/Users/zoo/esp32/esp-idf-fork/components/driver/include/driver/usb_serial_jtag.h:38:1: warning: missing initializer for member 'usb_serial_jtag_driver_config_t::tx_buffer_size' [-Wmissing-field-initializers]
 }
 ^
/Users/zoo/esp32/programs/console-advanced-cplusplus/main/console_example_main.cpp:106:47: note: in expansion of macro 'USB_SERIAL_JTAG_DRIVER_CONFIG_DEFAULT'
     const usb_serial_jtag_driver_config_t cfg=USB_SERIAL_JTAG_DRIVER_CONFIG_DEFAULT();
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/zoo/esp32/esp-idf-fork/components/driver/include/driver/usb_serial_jtag.h:38:1: error: designator order for field 'usb_serial_jtag_driver_config_t::tx_buffer_size' does not match declaration order in 'usb_serial_jtag_driver_config_t'
 }
 ^

@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 22, 2022
@github-actions github-actions bot changed the title usb_serial_jtag: make CONFIG_DEFAULT initializer match order of structure definition usb_serial_jtag: make CONFIG_DEFAULT initializer match order of structure definition (IDFGH-7218) Apr 22, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Apr 24, 2022
@suda-morris
Copy link
Collaborator

sha=9d93aef2b7d49527f2b263df84d5ecbc16822b9f

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Apr 25, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution, changes merged with 080953c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants