Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default PoP argument of esp_prov.get_security from None to string (IDFGH-5381) #7130

Closed
wants to merge 1 commit into from
Closed

Change default PoP argument of esp_prov.get_security from None to string (IDFGH-5381) #7130

wants to merge 1 commit into from

Conversation

alexhenrie
Copy link
Contributor

Closes IDFGH-5380

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 9, 2021
@github-actions github-actions bot changed the title Change default PoP argument of esp_prov.get_security from None to string Change default PoP argument of esp_prov.get_security from None to string (IDFGH-5381) Jun 9, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@shivani-tipnis
Copy link
Contributor

Hi @alexhenrie

The esp_prov.py provides the option whether you want to use PoP or not as a CLI argument.

Could you tell us your usecase for calling the function separately from a different script ?

Thanks

@alexhenrie
Copy link
Contributor Author

My biggest reason for importing functions from esp_prov.py, but not running esp_prov.py directly, is to send data to a series of custom endpoints, none of which is named "custom-data". It's clear that esp_prov.py was designed to allow importing its functions into other scripts because its main logic is disabled by the if __name__ == '__main__': statement when importing.

@shivani-tipnis
Copy link
Contributor

Thank you.

@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Opened Issue is new and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Jul 5, 2021
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Jul 14, 2021
espressif-bot pushed a commit that referenced this pull request Jul 16, 2021
@alexhenrie @shivani-tipnis
Change default PoP argument of esp_prov.get_security from None to string
5ed53c2 
Signed-off-by: Shivani Tipnis <[email protected]>
Merges #7130
Closes IDFGH-5380
@mahavirj
Copy link
Member

Fixed with 5ed53c2, thank you for your contribution.

@mahavirj mahavirj closed this Jul 16, 2021
@alexhenrie
Copy link
Contributor Author

Thank you!

@alexhenrie alexhenrie deleted the get_security branch July 16, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default argument to esp_prov.get_security causes a TypeError (IDFGH-5380)
5 participants
@alexhenrie @Alvin1Zhang @shivani-tipnis @mahavirj @espressif-bot