Fixed error in "touch_ll_get_sleep_time" function for ESP32 (IDFGH-5111) #6895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
espressif-bot
added
Status: In Progress
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
Jun 6, 2021
|
Thanks for contribution again, changes merged with 850de61. |
espressif-bot
pushed a commit
that referenced
this pull request
Jan 16, 2022
espressif-bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
espressif-bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this bug touch_hal_get_sleep_time() returns wrong value (both, sleep_cycle and meas_cycle filled with meas_cycle). As result, touch_pad_get_meas_time returns wrong sleep_cycle too.
Additional, bad side effect, touch_pad_config() makes wrong vTaskDelay() (because delay based on values returned by touch_pad_get_meas_time())