Modify method to get base directory. (IDFGH-4926) #6718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current method assumes that you are in the esp-idf directory when executing install. This method will get the correct path regardless of where you execute from.
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
Hi @blakjak44, will #6416 work for you to solve the issue? That PR is already in the merge queue, if it's okay for you we will merge it instead. |
|
Hi @igrr, personally, I think this method is better, as #6416 adds a period into the generated path. But as long as #6416 works then it's fine by me.
|
espressif-bot
pushed a commit
that referenced
this pull request
Apr 15, 2021
Current method assumes that you are in the esp-idf directory when executing install. This method will get the correct path regardless of where you execute from. Merges #6718
|
Thank you for the PR @blakjak44, it was cherry-picked as f5f0648! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current method assumes that you are in the esp-idf directory when executing install. This method will get the correct path regardless of where you execute from.