Fix double project idf_ext.py loading (IDFGH-3287) #5278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
@BrianPugh Thanks for your contribution. |
|
Hi @BrianPugh I thought twice and realised that making path as a set is not a good idea, extension_dirs = [realpath(idf_py_extensions_path)]
extra_paths = os.environ.get("IDF_EXTRA_ACTIONS_PATH")
if extra_paths is not None:
for path in extra_paths.split(';'):
path = realpath(path)
if path not in extension_dirs:
extension_dirs.append(path)
extensions = {}Could you please update the PR? |
|
updated! |
kumekay
reviewed
May 13, 2020
tools/idf.py
Outdated
| extra_paths = os.environ.get("IDF_EXTRA_ACTIONS_PATH", "").split(';') | ||
| extension_dirs = [idf_py_extensions_path] + extra_paths | ||
| extensions = {} | ||
| # Make a set to automatically handle duplicate paths |
There was a problem hiding this comment.
This comment doesn't make sense anymore,
and could you remove it and squish all commits into one?
There was a problem hiding this comment.
fixed and squashed
…d cwd if IDF_EXTRA_ACTIONS_PATH is not set.
BrianPugh
force-pushed
the
bug/double_idf_ext
branch
from
54e1e88 to
34a9238
Compare
espressif-bot
pushed a commit
that referenced
this pull request
May 18, 2020
…d cwd if IDF_EXTRA_ACTIONS_PATH is not set. Merges #5278
|
merged in 3a6b8bb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #5193 . I did not combine the project extension loading with the generic built-in extension loading since it'd be slightly backward incompatible (but would have reduced ~10 lines of code).