Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not #define bool when compiling in C++ (IDFGH-3078) #5100

Closed
wants to merge 1 commit into from
Closed

Do not #define bool when compiling in C++ (IDFGH-3078) #5100

wants to merge 1 commit into from

Conversation

strikosn
Copy link
Contributor

Redefining bool, true and false breaks C++ builds which include BLE mesh headers. Guarding with #ifdef resolves the problem.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Do not #define bool when compiling in C++. Do not #define bool when compiling in C++. (IDFGH-3078) Apr 11, 2020
@strikosn strikosn changed the title Do not #define bool when compiling in C++. (IDFGH-3078) Do not #define bool when compiling in C++ (IDFGH-3078) Apr 11, 2020
@Alvin1Zhang
Copy link
Collaborator

@strikosn Thanks for your contribution.

@Campou
Copy link

Campou commented Apr 13, 2020

Hi @strikosn

Thanks for the PR, could you please add a header ble_mesh: in the commit message?

Thanks.

@strikosn
Copy link
Contributor Author

Added.

@strikosn
Copy link
Contributor Author

I'm not authorized to merge this PR. Should I push into another branch?

@Campou
Copy link

Campou commented Apr 16, 2020

Hi @strikosn

Currently I can only review the code, not authorized to merge it.

And based on our Wiki, I need to submit a MR internally, which contains the same information with this PR (i.e. author, commit message, sign-off, etc.). When the MR is merged internally, it will be synchronized to Github.

Thanks.

@Campou
Copy link

Campou commented Jun 13, 2020

Hi @strikosn

I have submitted a MR for this PR internally, it will be merged soon.
And after some internal discussion, we decided to remove the boolean definitions in this header file entirely, since stdbool.h is already included for C.

Thanks.

@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution, please refer to 371d590, will close the PR now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants