Update i2s.c ( optimisation ) (IDFGH-2408) #4522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize the code to eliminate 1 line of redundant code.
github-actions
bot
changed the title
|
@joncmaloney Thanks for the contribution. |
|
|
shubhamkulkarni97
pushed a commit
to shubhamkulkarni97/esp-idf
that referenced
this pull request
May 28, 2020
…atch the TRM bug.
When I2S `i2s_comm_format_t` is set to `I2S_COMM_FORMAT_I2S_MSB`, the data should launch at first BCK. But not in fact, this MR fixed this issue.
For compatibility, several nwe parameters have been added, and the old parameters will be removed in the future.
closes espressif#5065
closes espressif#4957
closes espressif#2978
closes espressif#5136
Merges espressif#4522
|
Thanks for your contribution, please refer to b3587ff, will close the PR now. Thanks. |
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the code to eliminate 1 line of redundant code and use variable (bits) already on the stack rather than using the structure value from the array.