Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2s intrerrupt fix (IDFGH-9654) #10997

Closed
wants to merge 1 commit into from
Closed

i2s intrerrupt fix (IDFGH-9654) #10997

wants to merge 1 commit into from

Conversation

dizcza
Copy link
Contributor

@dizcza dizcza commented Mar 15, 2023

Fixes #10994

@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 15, 2023
@github-actions github-actions bot changed the title i2s intrerrupt fix i2s intrerrupt fix (IDFGH-9654) Mar 15, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@dizcza
Copy link
Contributor Author

dizcza commented Mar 16, 2023

Don't know why CI complains.

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Mar 20, 2023
Copy link
Collaborator

@L-KAYA L-KAYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dizcza Really thanks for your bugfix and apologize for the careless bug

components/driver/i2s/i2s_std.c Show resolved Hide resolved
components/driver/i2s/include/driver/i2s_common.h Outdated Show resolved Hide resolved
@L-KAYA
Copy link
Collaborator

L-KAYA commented Mar 20, 2023

Don't know why CI complains.

The Ci failed due to the copyright date is not updated, you can install the pre-commit hook (see how to install the pre-commit hook) before adding the commit, it will help to fix the copyright issue.

@dizcza
Copy link
Contributor Author

dizcza commented Mar 20, 2023

The Ci failed due to the copyright date is not updated, you can install the pre-commit hook (see how to install the pre-commit hook) before adding the commit, it will help to fix the copyright issue.

that's exactly what I did in my latest commit

@L-KAYA
Copy link
Collaborator

L-KAYA commented Mar 20, 2023

that's exactly what I did in my latest commit

To trigger the copyright check, you may need to do a soft reset and commit again.
BTW, could you please also squash the commit, the first commit seems change nothing, thanks!

@dizcza
Copy link
Contributor Author

dizcza commented Mar 20, 2023

Done.

could you please also squash the commit

I squashed and did a force push but come on, you can always squash the commits on merging a pull request. Or did you set up non-sqush merge rules?

@L-KAYA
Copy link
Collaborator

L-KAYA commented Mar 28, 2023

sha=7e91f1ae55a51cbd53cec5754799cd515b8d857d

@L-KAYA L-KAYA added the PR-Sync-Merge Pull request sync as merge commit label Mar 28, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Selected for Development Issue is selected for development labels Mar 28, 2023
espressif-bot pushed a commit that referenced this pull request Mar 31, 2023
@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: In Progress Work is in progress labels Mar 31, 2023
espressif-bot pushed a commit that referenced this pull request Apr 3, 2023
@suda-morris suda-morris closed this Apr 4, 2023
@suda-morris
Copy link
Collaborator

Merged as b44c89d

espressif-bot pushed a commit that referenced this pull request Apr 10, 2023
espressif-bot pushed a commit that referenced this pull request May 5, 2023
espressif-bot pushed a commit that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read I2S data when I2C & UART are active (IDFGH-9650)
5 participants