-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export: avoid error on unbound variable (IDFGH-9586) #10935
export: avoid error on unbound variable (IDFGH-9586) #10935
Conversation
Hi @MarcFinetRtone , |
To describe here in the PR or in the commit message ? Regarding the change:
It's the same problem fixed by 1673183 (but don't know why A workaround is to export |
@MarcFinetRtone Thank you for clearing it up for me, I can see the issue now. While testing it, I discovered the same problem with the unbound variable with |
I the shell has `set -u` (to abort on unbound variable), sourcing export.sh currently fails when IDF_EXPORT_QUIET or IDF_PATH is not set: > /path/to/esp-idf/export.sh:16: IDF_EXPORT_QUIET: unbound variable This commit sets a default empty value to those variable, as done in 1673183 (which forgot IDF_PATH as it's usually set, the other variable landed later in the file).
76db9d6
to
13e59ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcFinetRtone Thank you for your contribution and cooperation.
sha=13e59ed7a99f6bf7ee3d851faeee1fd4b3261ea5 |
Might stop sourcing export.sh when
set -u
is used (typically with direnv):