Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2c cmdnum fix (IDFGH-9444) #10811

Closed
wants to merge 2 commits into from

Conversation

BitsForPeople
Copy link
Contributor

@BitsForPeople BitsForPeople commented Feb 21, 2023

The I2C driver used a hard-coded limit of 16 COMMAND registers, while some ESPs have 16 and some only have 8 of those.
Added respective #defines to soc_caps.h and make use of them in i2c.c.

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 21, 2023
@github-actions github-actions bot changed the title I2c cmdnum fix I2c cmdnum fix (IDFGH-9444) Feb 21, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@suda-morris
Copy link
Collaborator

sha=6e8a85860d0dcc775ec5b93d442b22aeed4482d5

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Feb 22, 2023
@AxelLin
Copy link
Contributor

AxelLin commented Mar 19, 2023

sha=6e8a85860d0dcc775ec5b93d442b22aeed4482d5

@suda-morris Any update for this PR?

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Apr 23, 2023
espressif-bot pushed a commit that referenced this pull request Apr 25, 2023
@suda-morris suda-morris closed this Jun 5, 2023
espressif-bot pushed a commit that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants