Set errno in adjtime (IDFGH-8915)
#10334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other time functions (e.g. settimeofday) set errno to ENOSYS if IMPL_NEWLIB_TIME_FUNCS is not set. adjtime should probably do the same.
errno should be set to EINVAL in this case according to adjtime's man page.
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
sha=60767c234daaea9dfa8b4fa8f721f565b163c3e0 |
jofrev
changed the title
errno in adjtime (IDFGH-8915)
espressif-bot
added
Resolution: NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to other time function implementations (e.g.
settimeofday) and its man page,adjtimedoes not seterrnoin case it fails.There are two possible scenarios for
adjtimeto fail at the moment:errnoshould be set toEINVALaccording to the man pagesettimeofday) returnENOSYSin this caseThis pull request fixes both.
Maybe this is something that should also be fixed in some of the older stable releases which are still in maintenance period. What do you think? I would love to see it fixed for v4.4 at least, which is the version I discovered this on 😉