You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The S3 version of rmt_reg.h adds 4 new RX Limit registers: RMT_CH4_RX_LIM_REG, RMT_CH5_RX_LIM_REG, RMT_CH6_RX_LIM_REG, and RMT_CH7_RX_LIM_REG. However, in the code that defines the masks for these registers, the macro names seem to have been mislabeled, which causes duplicate, inconsistent definitions of the _REG macros. For example:
/** RMT_CH4_RX_LIM_REG register * Channel 4 Rx event configuration register*/
#defineRMT_CH4_RX_LIM_REG (DR_REG_RMT_BASE + 0xb0)
/** RMT_CH4_RX_LIM_REG : R/W; bitpos: [8:0]; default: 128; * This register is used to configure the maximum entries that CHANNEL4 can receive.*/
#defineRMT_CH4_RX_LIM_REG0x000001FFU
#defineRMT_CH4_RX_LIM_REG_M (RMT_CH4_RX_LIM_REG_V << RMT_CH4_RX_LIM_REG_S)
#defineRMT_CH4_RX_LIM_REG_V0x000001FFU
#defineRMT_CH4_RX_LIM_REG_S0
should instead be
/** RMT_CH4_RX_LIM_REG register * Channel 4 Rx event configuration register*/
#defineRMT_CH4_RX_LIM_REG (DR_REG_RMT_BASE + 0xb0)
/** RMT_CH4_RX_LIM_REG : R/W; bitpos: [8:0]; default: 128; * This register is used to configure the maximum entries that CHANNEL4 can receive.*/
#defineRMT_CH4_RX_LIM0x000001FFU
#defineRMT_CH4_RX_LIM_M (RMT_CH4_RX_LIM_REG_V << RMT_CH4_RX_LIM_REG_S)
#defineRMT_CH4_RX_LIM_V0x000001FFU
#defineRMT_CH4_RX_LIM_S0
Consistent with how all other macros are defined in the file, the suffix "_REG" should not be included on the 4 mask macros definitions. This leads to a redefinition of actual register address, RMT_CH4_RX_LIM_REG (DR_REG_RMT_BASE + 0xb0), with the wrong value (0x000001FFU). In contrast, note how the original TX Limit registers are correctly defined in the file, and the distinction between RMT_CH3_TX_LIM_REG and RMT_CH3_TX_LIM:
/** RMT_CH3_TX_LIM_REG register * Channel 3 Tx event configuration register*/
#defineRMT_CH3_TX_LIM_REG (DR_REG_RMT_BASE + 0xac)
/** RMT_TX_LIM_CH3 : R/W; bitpos: [8:0]; default: 128; * This register is used to configure the maximum entries that CHANNEL3 can send out.*/
#defineRMT_TX_LIM_CH30x000001FFU
#defineRMT_TX_LIM_CH3_M (RMT_TX_LIM_CH3_V << RMT_TX_LIM_CH3_S)
#defineRMT_TX_LIM_CH3_V0x000001FFU
#defineRMT_TX_LIM_CH3_S0
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
s3 version of rmt_reg.h contains conflicting #defines for the RX Limit registers of channels 4-7
s3 version of rmt_reg.h contains conflicting #defines for the RX Limit registers of channels 4-7 (IDFGH-7537)
Jun 4, 2022
The S3 version of rmt_reg.h adds 4 new RX Limit registers: RMT_CH4_RX_LIM_REG, RMT_CH5_RX_LIM_REG, RMT_CH6_RX_LIM_REG, and RMT_CH7_RX_LIM_REG. However, in the code that defines the masks for these registers, the macro names seem to have been mislabeled, which causes duplicate, inconsistent definitions of the _REG macros. For example:
should instead be
Consistent with how all other macros are defined in the file, the suffix "_REG" should not be included on the 4 mask macros definitions. This leads to a redefinition of actual register address, RMT_CH4_RX_LIM_REG (DR_REG_RMT_BASE + 0xb0), with the wrong value (0x000001FFU). In contrast, note how the original TX Limit registers are correctly defined in the file, and the distinction between RMT_CH3_TX_LIM_REG and RMT_CH3_TX_LIM:
The text was updated successfully, but these errors were encountered: