You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This statement was deleted: _#ifdef _cplusplus
}
#endif
But this statement still remains unchanged: _#ifdef _cplusplus
extern "C" {
#endif
This results in missing "}" clause, causing havoc if secure boot is used in ESP-IDF-v4.
See compilation output below.
Expected Behavior
Compilation successful.
Actual Behavior
Compilation fails.
Steps to reproduce
Compile with secure boot enabled and include <esp_secure_boot.h>
Debug Logs
../main/Machine.cpp:1538:1: error: expected '}' at end of input
}
^
In file included from ../esp/esp-idf/components/bootloader_support/include/esp_secure_boot.h:25,
from ../main/Machine.cpp:34:
../esp/esp-idf/components/esp_rom/include/esp32/rom/secure_boot.h:23:12: note: to match this '{'
extern "C" {
^
ninja: build stopped: subcommand failed.
ninja failed with exit code 1
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
In 'secure_boot.h' a 'extern "C" {' statement is missing a closing '}' resulting in failed compilation esp-idf-v4.1
In 'secure_boot.h' a 'extern "C" {' statement is missing a closing '}' resulting in failed compilation esp-idf-v4.1 (IDFGH-3998)
Sep 17, 2020
Environment
git describe --tags
to find it): v4.1-273-g94cb7e8b8xtensa-esp32-elf-gcc --version
to find it): xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0Problem Description
Quite simply, on commit: 60fed38
File path:
esp-idf/components/esp_rom/include/esp32/rom/secure_boot.h
This statement was deleted:
_#ifdef _cplusplus
}
#endif
But this statement still remains unchanged:
_#ifdef _cplusplus
extern "C" {
#endif
This results in missing "}" clause, causing havoc if secure boot is used in ESP-IDF-v4.
See compilation output below.
Expected Behavior
Compilation successful.
Actual Behavior
Compilation fails.
Steps to reproduce
Compile with secure boot enabled and include <esp_secure_boot.h>
Debug Logs
The text was updated successfully, but these errors were encountered: