Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI Master - second device (spi_bus_add_device) does not work (IDFGH-91) #1080

Closed
OtherCrashOverride opened this issue Oct 5, 2017 · 4 comments
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@OtherCrashOverride
Copy link

When using spi_bus_add_device to add two devices to a SPI bus with different CS lines, the second device does not operate properly if one is half duplex and the other full duplex. If both are full duplex, the issue does not occur.

@Spritetm
Copy link
Member

Spritetm commented Oct 6, 2017

Can you expand a bit on 'does not operate properly'? What symptoms do you notice?

@OtherCrashOverride
Copy link
Author

Due to time constraints, I did not have the opportunity to explore what exactly "does not operate properly" entails.

The configuration being tested is an ILI9341 SPI display as the first SPI device and a XPT2046 touch panel interface as the second SPI device. The first device is configured in half duplex mode while the second is full duplex. When either is the only device added (spi_bus_add_device), correct operation is observed. When the display is added followed by the touch panel, the touch panel does not report correct data. Changing the display device to full duplex yields correct operation of both devices.

@FayeY FayeY changed the title SPI Master - second device (spi_bus_add_device) does not work [TW#15765] SPI Master - second device (spi_bus_add_device) does not work Oct 11, 2017
@projectgus projectgus changed the title [TW#15765] SPI Master - second device (spi_bus_add_device) does not work SPI Master - second device (spi_bus_add_device) does not work (IDFGH-91) Mar 12, 2019
@ginkgm
Copy link
Collaborator

ginkgm commented May 6, 2021

Hi @OtherCrashOverride ,

Sorry for long long no-reply ....

The issue was reported quite long ago, during which we have introduced a similar issue on 4.0 and fix it on master (see: #4641). (The fix backporting to 4.0, 4.1 and 4.2 are in progress....)

Please help test again, or wait for patches to 4.0-4.2. (they will also close this issue upon merged)

@Alvin1Zhang
Copy link
Collaborator

Thanks for reporting and sorry for slow turnaround.

Feel free to reopen.

@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally labels Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

5 participants