Skip to content

Commit

Permalink
Make export.fish exit with SUCCESS exit code
Browse files Browse the repository at this point in the history
The export.fish script exits with an exit code of 4. Thus, any shell checks that make sure the source command exits successfully always failed. This was due to the last line trying to erase the __main function. In fish, you can't erase a function using the `set` command, you can only erase variables. By removing that line the script now exits with an exit code of 0 instead of 4.

Erase __main function at the end of export.fish

Closes #10828
  • Loading branch information
maxslarsson authored and Marek Fiala committed Mar 17, 2023
1 parent 7cfc1a7 commit 3ed0f16
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions export.fish
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,4 @@ else
eval (env _IDF.PY_COMPLETE=fish_source idf.py)
end


set -e __main
functions -e __main

0 comments on commit 3ed0f16

Please sign in to comment.