-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
framebuffer: esp-box/esp-box-lite use framebuf height form Kconfig (BSP-331) #186
framebuffer: esp-box/esp-box-lite use framebuf height form Kconfig (BSP-331) #186
Conversation
Hello @espressif2022 , you are right, the frame buffer is not easily configurable now. We were thinking about making it configurable in runtime (as opposed to you suggestion with Kconfig). lv_disp_t *bsp_display_start_with_config(lvgl_port_cfg_t *cfg); This would allow users to configure their cc @espzav |
|
Yep, RGB screens are not yet supported by So, unless this PR is not in a hurry, I'd suggest waiting a little. Then we can come up with API that would allow configuration of framebuffers for all LCDs (SPI, RGB...) |
You are thoughtful,but there's a little urgency now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At present, on some examples, the RAM is insufficient, and rainmaker fails to run, so submit this PR.
Understood. I left one commit about using bool instead of int in Kconfig. Apart from that LGTM!
f60ddff
to
2a1e702
Compare
2a1e702
to
40a0100
Compare
@espressif2022 I rebased your branch on top of #188, which should fix the CI |
ok. |
40a0100
to
67cb318
Compare
ESP-BSP Pull Request checklist
Change description
In some scenarios, the remaining SRAM is insufficient, make the num of framebuf height to configurable.