Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framebuffer: esp-box/esp-box-lite use framebuf height form Kconfig (BSP-331) #186

Merged

Conversation

espressif2022
Copy link
Contributor

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

In some scenarios, the remaining SRAM is insufficient, make the num of framebuf height to configurable.

@tore-espressif
Copy link
Collaborator

Hello @espressif2022 , you are right, the frame buffer is not easily configurable now.

We were thinking about making it configurable in runtime (as opposed to you suggestion with Kconfig).
We wanted to introduce new API, that would extend the current bsp_display_start() like this:

lv_disp_t *bsp_display_start_with_config(lvgl_port_cfg_t *cfg);

This would allow users to configure their esp_lvgl_port and framebuffer settings on runtim, what do you think?

cc @espzav

@github-actions github-actions bot changed the title framebuffer: esp-box/esp-box-lite use framebuf height form Kconfig framebuffer: esp-box/esp-box-lite use framebuf height form Kconfig (BSP-331) Jun 28, 2023
@espressif2022
Copy link
Contributor Author

Hello @espressif2022 , you are right, the frame buffer is not easily configurable now.

We were thinking about making it configurable in runtime (as opposed to you suggestion with Kconfig). We wanted to introduce new API, that would extend the current bsp_display_start() like this:

lv_disp_t *bsp_display_start_with_config(lvgl_port_cfg_t *cfg);

This would allow users to configure their esp_lvgl_port and framebuffer settings on runtim, what do you think?

cc @espzav
@tore-espressif ,good suggestion.
This is needed for spi screens, probably useless for RGB screens.
This modification is only for the screen of SPI interface, will it affect the consistency of the interface(bsp_display_start())?

@tore-espressif
Copy link
Collaborator

This is needed for spi screens, probably useless for RGB screens.
This modification is only for the screen of SPI interface, will it affect the consistency of the interface(bsp_display_start())?

Yep, RGB screens are not yet supported by esp_lvgl_port , it is planned in following months.

So, unless this PR is not in a hurry, I'd suggest waiting a little. Then we can come up with API that would allow configuration of framebuffers for all LCDs (SPI, RGB...)

@espressif2022
Copy link
Contributor Author

This is needed for spi screens, probably useless for RGB screens.
This modification is only for the screen of SPI interface, will it affect the consistency of the interface(bsp_display_start())?

Yep, RGB screens are not yet supported by esp_lvgl_port , it is planned in following months.

So, unless this PR is not in a hurry, I'd suggest waiting a little. Then we can come up with API that would allow configuration of framebuffers for all LCDs (SPI, RGB...)

You are thoughtful,but there's a little urgency now.
Recently, many developers urged us to update esp-box-lite, and now the examples of esp-box-lite have been componentized and are waiting to be released.
At present, on some examples, the RAM is insufficient, and rainmaker fails to run, so submit this PR.

esp-box/Kconfig Outdated Show resolved Hide resolved
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At present, on some examples, the RAM is insufficient, and rainmaker fails to run, so submit this PR.

Understood. I left one commit about using bool instead of int in Kconfig. Apart from that LGTM!

@espressif2022 espressif2022 force-pushed the feature/box_framebuf_height branch from f60ddff to 2a1e702 Compare June 28, 2023 11:58
@tore-espressif tore-espressif force-pushed the feature/box_framebuf_height branch from 2a1e702 to 40a0100 Compare June 29, 2023 10:12
@tore-espressif
Copy link
Collaborator

@espressif2022 I rebased your branch on top of #188, which should fix the CI

@espressif2022
Copy link
Contributor Author

@espressif2022 I rebased your branch on top of #188, which should fix the CI

ok.

@espressif2022 espressif2022 force-pushed the feature/box_framebuf_height branch from 40a0100 to 67cb318 Compare June 29, 2023 10:44
@tore-espressif tore-espressif merged commit 99a43ef into espressif:master Jun 29, 2023
@espressif2022 espressif2022 deleted the feature/box_framebuf_height branch May 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants