-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lcd: add gc9503 lcd driver #185
lcd: add gc9503 lcd driver #185
Conversation
@tore-espressif @espzav PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR @Lzw655 ! I left few comments
Could you please also add this new driver to this table? https://github.com/espressif/esp-bsp/blob/master/LCD.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is a bug in CI that is being fixed by idf_tools team, let's wait until it is resolved
@tore-espressif Thank you for reviewing! I modify someplace according to your comments. But there is a CI error below. Can you help me to check it?
|
Another problem: This component just supports esp32s3. How can I avoid some checks for other chips? |
You can rebase on top of this #188 to fix the problem EDIT: Already rebased! |
5b699bf
to
68dd7fd
Compare
68dd7fd
to
43d5781
Compare
ESP-BSP Pull Request checklist
Change description
Add a new RGB LCD. It is used by ESP32-S3-LCD-Ev-Board BSP.