Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcd: add gc9503 lcd driver #185

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

Lzw655
Copy link
Collaborator

@Lzw655 Lzw655 commented Jun 28, 2023

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Add a new RGB LCD. It is used by ESP32-S3-LCD-Ev-Board BSP.

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 28, 2023

@tore-espressif @espzav PTAL, thanks!

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR @Lzw655 ! I left few comments

Could you please also add this new driver to this table? https://github.com/espressif/esp-bsp/blob/master/LCD.md

components/lcd/esp_lcd_gc9503/idf_component.yml Outdated Show resolved Hide resolved
components/lcd/esp_lcd_gc9503/include/esp_lcd_gc9503.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There is a bug in CI that is being fixed by idf_tools team, let's wait until it is resolved

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 28, 2023

@tore-espressif Thank you for reviewing! I modify someplace according to your comments. But there is a CI error below. Can you help me to check it?

2023-06-28 08:31:36  WARNING >>> /opt/esp/idf/tools/check_python_dependencies.py:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
2023-06-28 08:31:36    ERROR >>> Build succeeded with warnings

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 28, 2023

Another problem: This component just supports esp32s3. How can I avoid some checks for other chips?

@tore-espressif
Copy link
Collaborator

tore-espressif commented Jun 29, 2023

@tore-espressif Thank you for reviewing! I modify someplace according to your comments. But there is a CI error below. Can you help me to check it?

2023-06-28 08:31:36  WARNING >>> /opt/esp/idf/tools/check_python_dependencies.py:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
2023-06-28 08:31:36    ERROR >>> Build succeeded with warnings

You can rebase on top of this #188 to fix the problem

EDIT: Already rebased!

@tore-espressif tore-espressif force-pushed the feature/add_esp_lcd_gc9503 branch from 5b699bf to 68dd7fd Compare June 29, 2023 10:12
@Lzw655 Lzw655 force-pushed the feature/add_esp_lcd_gc9503 branch from 68dd7fd to 43d5781 Compare June 29, 2023 11:56
@tore-espressif tore-espressif merged commit fa9dd75 into espressif:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants