Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: Use SPIFFS init from BSP #184

Merged
merged 1 commit into from
Jun 21, 2023
Merged

example: Use SPIFFS init from BSP #184

merged 1 commit into from
Jun 21, 2023

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Jun 20, 2023 •
edited
Loading

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

@espzav
Copy link
Collaborator Author

espzav commented Jun 20, 2023

@tore-espressif PTAL

@espzav espzav force-pushed the examples/spiffs_in_display_audio_photo branch from b741630 to 3acc49b Compare June 20, 2023 13:29
tore-espressif
tore-espressif approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nitpick, LGTM!

examples/display_audio_photo/main/app_disp_fs.c Outdated Show resolved Hide resolved
@espzav espzav force-pushed the examples/spiffs_in_display_audio_photo branch from 3acc49b to 1f65d68 Compare June 21, 2023 05:50
@espzav
Copy link
Collaborator Author

espzav commented Jun 21, 2023

@tore-espressif Thank you for the review!

@espzav espzav merged commit ab64673 into master Jun 21, 2023
@espzav espzav deleted the examples/spiffs_in_display_audio_photo branch June 21, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@espzav @tore-espressif