Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CST816: Extend the reset time and fix the interruption #181

Merged
merged 1 commit into from
Jun 15, 2023
Merged

CST816: Extend the reset time and fix the interruption #181

merged 1 commit into from
Jun 15, 2023

Conversation

Lzw655
Copy link
Collaborator

@Lzw655 Lzw655 commented Jun 14, 2023

Closes #178

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Fix bugs of esp_lcd_touch_cst816s

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 14, 2023

@espzav @tom-borcin PTAL, thanks!

@Lzw655 Lzw655 force-pushed the bugfix/fix_reset_timing branch from 2b687d9 to c71db32 Compare June 14, 2023 03:40
@Lzw655 Lzw655 marked this pull request as draft June 14, 2023 04:58
@Lzw655 Lzw655 marked this pull request as ready for review June 14, 2023 07:30
@Lzw655 Lzw655 mentioned this pull request Jun 14, 2023
Closed
@tom-borcin
Copy link

@espzav @tom-borcin PTAL, thanks!

I think you meant @tore-espressif

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 15, 2023

@espzav @tom-borcin PTAL, thanks!

I think you meant @tore-espressif

Yes, sorry about that...

espzav
espzav reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lzw655 Thank you very much for these changes! LGTM
Please, could you fix STMPE610 touch controller for interrupt_callback in the same PR? I overlooked before, there is the same issue. And then, please squash commits.

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 15, 2023

Sure, I'll do it. 👌

@Lzw655 Lzw655 force-pushed the bugfix/fix_reset_timing branch from 2214e8f to 8070b7c Compare June 15, 2023 06:56
@Lzw655
Copy link
Collaborator Author

Lzw655 commented Jun 15, 2023

@espzav All fixed. PTAL, thank you.

espzav
espzav approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lzw655 Thank you very much! LGTM

@espzav espzav merged commit 9151469 into espressif:master Jun 15, 2023
@Lzw655 Lzw655 deleted the bugfix/fix_reset_timing branch June 18, 2023 05:34
@shyney7 shyney7 mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espzav espzav espzav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CST816 Touch driver support (IDFGH-10255) (BSP-328)
4 participants
@Lzw655 @CLAassistant @tom-borcin @espzav