Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-DSP demo features for azure IoT dev board (BSP-296) #158

Merged

Conversation

peter-marcisovsky
Copy link
Collaborator

Change description

esp32_azure_iot_kit added I2C clk speed setter. Allowing faster display refresh rate. Supported setter for 100, 400 and 600 kHz. Also found out, mag3110 has troubles communicating on fast I2C.

ssd1306 added function to draw lines from provided XY coordinates.

mag3110 added function to start sesnor without previous calibration. ESP-DSP demo is using Kalman filter, which does the calibration by itself.

fbm320 added the highest OSR measurement

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2023

CLA assistant check
All committers have signed the CLA.

@peter-marcisovsky peter-marcisovsky changed the title esp-dsp demo features added ESP-DPS demo features for azure IoT dev board Apr 11, 2023
@github-actions github-actions bot changed the title ESP-DPS demo features for azure IoT dev board ESP-DPS demo features for azure IoT dev board (BSP-296) Apr 11, 2023
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @peter-marcisovsky !
I left few comments, but nothing major

components/fbm320/fbm320.c Outdated Show resolved Hide resolved
components/ssd1306/include/ssd1306.h Outdated Show resolved Hide resolved
components/ssd1306/include/ssd1306.h Outdated Show resolved Hide resolved
components/ssd1306/include/ssd1306.h Outdated Show resolved Hide resolved
components/ssd1306/ssd1306.c Show resolved Hide resolved
components/fbm320/fbm320.c Show resolved Hide resolved
components/mag3110/include/mag3110.h Outdated Show resolved Hide resolved
@tore-espressif tore-espressif changed the title ESP-DPS demo features for azure IoT dev board (BSP-296) ESP-DSP demo features for azure IoT dev board (BSP-296) Apr 19, 2023
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nitpick, rest LGTM!

components/mag3110/include/mag3110.h Outdated Show resolved Hide resolved
Co-authored-by: Tomas Rezucha <[email protected]>
@tore-espressif
Copy link
Collaborator

@peter-marcisovsky I'm sorry for the pre-commit troubles :/ We can merge after the formatting issue is resolved

@tore-espressif tore-espressif merged commit 989f826 into espressif:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants