-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples/optimization #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said before, I think that the example display_rotation can still be helpful for customers. I would like to add the example with rotation by the accelerometer, but we haven't got it in our boards now. Other LGTM.
dce3c4c
to
7df04f2
Compare
Thank you for the review @espzav . Display_rotation example restored! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tore-espressif could you please update README.md as well? https://github.com/espressif/esp-bsp#examples still lists the examples which have been removed. |
@igrr yes, the upload workflow is failing too. It seems that i was too hasty with merging 🤦 |
fix: Leftover from #153
ESP-BSP Pull Request checklist
Change description
-Wno-format
compile flagWe want to remove few rudimentary examples to offload the maintainers, so they can focus in improving existing examples
Closes #50