Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples/optimization #153

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Examples/optimization #153

merged 2 commits into from
Apr 21, 2023

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Apr 4, 2023

ESP-BSP Pull Request checklist

  • CI passing

Change description

  1. Fix format warnings and remove -Wno-format compile flag
  2. Remove few examples

We want to remove few rudimentary examples to offload the maintainers, so they can focus in improving existing examples

Closes #50

@tore-espressif tore-espressif self-assigned this Apr 4, 2023
@tore-espressif tore-espressif requested review from espzav and igrr April 19, 2023 11:55
@tore-espressif tore-espressif marked this pull request as ready for review April 19, 2023 12:01
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before, I think that the example display_rotation can still be helpful for customers. I would like to add the example with rotation by the accelerometer, but we haven't got it in our boards now. Other LGTM.

@tore-espressif tore-espressif force-pushed the examples/optimization branch from dce3c4c to 7df04f2 Compare April 21, 2023 13:27
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@tore-espressif
Copy link
Collaborator Author

As I said before, I think that the example display_rotation can still be helpful for customers. I would like to add the example with rotation by the accelerometer, but we haven't got it in our boards now. Other LGTM.

Thank you for the review @espzav . Display_rotation example restored!

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tore-espressif tore-espressif merged commit 6fde40c into master Apr 21, 2023
@tore-espressif tore-espressif deleted the examples/optimization branch April 21, 2023 14:23
@igrr
Copy link
Member

igrr commented Apr 21, 2023

@tore-espressif could you please update README.md as well? https://github.com/espressif/esp-bsp#examples still lists the examples which have been removed.

@tore-espressif
Copy link
Collaborator Author

@igrr yes, the upload workflow is failing too. It seems that i was too hasty with merging 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix format warnings (BSP-175)
4 participants