-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsp: Proposal of LCD API #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tore-espressif Thank you! Great work! Some comments left.
@espzav Changes compared to the initial proposal:
TODOs:
|
9eab7b3
to
f294043
Compare
@TTauriainenQt PTAL! |
Hi @tore-espressif, I did not find a way to set callback function for |
Hi @TTauriainenQt,
|
Ok, thank you! Pull request looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tore-espressif Thank you for this PR! Great work! Thank you for fix some minor issues in other BSPs. Some notes:
- Same as LCD should be new function for touch init. Do you plan it in next PR?
- The EV board is missing the
bsp_display_new
function. - Did you test all on hardware?
Thanks!
f294043
to
e74b365
Compare
@espzav Thank you very much for the review!
|
This PR allows LCD initialization without LVGL. The API is in a separate file
bsp/lcd.h
to indicate that it is not needed in usual usacases.I'd like to discuss few issues before I implement it for all BSPs:
Should we extend the backlight_init function with variable LEDC channels and timers? (the user can, after all, implement his own backlight control)Any ideas welcome!
Related #121