Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bsp/improve_s3-lcd-ev-board #129

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

Lzw655
Copy link
Collaborator

@Lzw655 Lzw655 commented Feb 13, 2023

Checklist for new Board Support package or Component

  • Component contains License
  • Component contains README.md
  • Project README.md updated
  • Component contains idf_component.yml file with url field defined
  • Component was added to CI upload job
  • New files were added to CI build job
  • Optional: Component contains unit tests
  • CI passing

Change description

  • Configurations:
    • Support to set number of frame buffers for RGB
    • Support to use bounce-buffer for RGB
    • Support to change the minimum delay time of LVGL task
    • Support to change the stack size of LVGL task
    • Support to enable anti-tearing function simply by using multiple buffers
  • RGB Anti-tearing:
    • Optimize direct mode (increase FPS from 14 to 17, tested by display_lvgl_demos)
    • Use triple-buffer in full-refresh mode (increase FPS from 13 to 16, tested by display_lvgl_demos)

Also, update README and sdkconfig of display_lvgl_demos example.

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Feb 13, 2023

@espzav @tore-espressif Hi, I add some new configurations and improve anti-tearing scheme for esp32-s3-lcd-ev-board BSP. They can achieve higher performance than before. PTAL, thank you very much.

@Lzw655 Lzw655 changed the title Bsp/s3 lcd ev board improve Bsp/improve_s3-lcd-ev-board Feb 13, 2023
@tore-espressif
Copy link
Collaborator

@Lzw655 thanks for the PR. I haven't tried it on HW yet, though

@suda-morris could you please have a look too?

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lzw655 thank you for this review. I tried on HW with 800x480 and it is working good. But I don't understand other settings of the RGB (buffers, tearing etc.). When I tried change settings, in all combination was really worst that default settings (in FPS). Other LGTM.

Next note, it will be nice to add RGB LCD support into LVGL port. I would like do it in future, but I must to more understand before it.

@Lzw655
Copy link
Collaborator Author

Lzw655 commented Feb 24, 2023

@Lzw655 thank you for this review. I tried on HW with 800x480 and it is working good. But I don't understand other settings of the RGB (buffers, tearing etc.). When I tried change settings, in all combination was really worst that default settings (in FPS). Other LGTM.

Next note, it will be nice to add RGB LCD support into LVGL port. I would like do it in future, but I must to more understand before it.

Thank you for testing it! When using the anti-tearing function, compared with the default settings, it will definitely lead to a lower FPS. Because this function uses PSRAM as the LVGL buffer while default settings use SRAM. And, I also expect RGB LCD support in LVGL port.

@Lzw655 Lzw655 force-pushed the bsp/s3-lcd-ev-board_improve branch from d2e9598 to 2c775bf Compare February 24, 2023 06:23
s3-lcd-ev-board: add triple-buffer for full-refresh

s3-lcd-ev-board: update README and sdkconfig of example

s3-lcd-ev-board: add changelog

s3-lcd-ev-board: move BSP's configs from example to BSP

s3-lcd-ev-board: remove useless flag ERR
@Lzw655 Lzw655 force-pushed the bsp/s3-lcd-ev-board_improve branch from 2c775bf to a594afa Compare February 28, 2023 06:03
@Lzw655
Copy link
Collaborator Author

Lzw655 commented Feb 28, 2023

@espzav @tore-espressif Can we merge it now? After this, we will update examples and the factory bin in esp-dev-kits.

@espzav espzav merged commit 579c1ac into espressif:master Feb 28, 2023
@Lzw655 Lzw655 deleted the bsp/s3-lcd-ev-board_improve branch February 28, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants