-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bsp/improve_s3-lcd-ev-board #129
Conversation
@espzav @tore-espressif Hi, I add some new configurations and improve anti-tearing scheme for esp32-s3-lcd-ev-board BSP. They can achieve higher performance than before. PTAL, thank you very much. |
@Lzw655 thanks for the PR. I haven't tried it on HW yet, though @suda-morris could you please have a look too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lzw655 thank you for this review. I tried on HW with 800x480 and it is working good. But I don't understand other settings of the RGB (buffers, tearing etc.). When I tried change settings, in all combination was really worst that default settings (in FPS). Other LGTM.
Next note, it will be nice to add RGB LCD support into LVGL port. I would like do it in future, but I must to more understand before it.
Thank you for testing it! When using the anti-tearing function, compared with the default settings, it will definitely lead to a lower FPS. Because this function uses PSRAM as the LVGL buffer while default settings use SRAM. And, I also expect RGB LCD support in LVGL port. |
d2e9598
to
2c775bf
Compare
s3-lcd-ev-board: add triple-buffer for full-refresh s3-lcd-ev-board: update README and sdkconfig of example s3-lcd-ev-board: add changelog s3-lcd-ev-board: move BSP's configs from example to BSP s3-lcd-ev-board: remove useless flag ERR
2c775bf
to
a594afa
Compare
@espzav @tore-espressif Can we merge it now? After this, we will update examples and the factory bin in esp-dev-kits. |
Checklist for new Board Support package or Component
url
field definedChange description
Also, update README and sdkconfig of display_lvgl_demos example.