esp_lvgl_port: Add maximum time in ms for sleep LVGL task. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@espzav Could you please set the timeout to 500, in case the user passes 0? This will ensure backward compatibility for cases where users do not use |
espzav
force-pushed
the
lvgl_port_add_max_sleep_time
branch
from
ae1db85 to
96b030f
Compare
Good point! Fixed. Thank you @tore-espressif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is another minor change in LVGL port, which we need for
esp32_s3_eyeBSP. We need to not sleep during the LVGL task. I added a maximum time in ms, for which the task can sleep.