Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unicode issues when utf-8 encoding is not set in system #23

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

tomassebestik
Copy link
Member

@tomassebestik tomassebestik commented Apr 7, 2024

Removing unicode emojis (#22 )

  • fix: unicode issues when utf-8 encoding is not set in system
  • updated image thumbnails in docs

Fixes breaking change character displaying in output message (#24 )

Related

Notes

  • published as v1.8.0-beta pre-release (to allow testing)

Copy link

github-actions bot commented Apr 7, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello tomassebestik, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5c4cd8d

@tomassebestik tomassebestik force-pushed the fix/unicode-issues-windows branch from 65471f8 to 82dc176 Compare April 7, 2024 08:19
@tomassebestik tomassebestik added Awaiting Response Awaiting a response from the author Status: Reviewing Issue is being reviewed labels Apr 7, 2024
@tomassebestik tomassebestik force-pushed the fix/unicode-issues-windows branch from 6b01866 to 6adc2fb Compare April 17, 2024 06:48
@tomassebestik tomassebestik force-pushed the fix/unicode-issues-windows branch from 6adc2fb to 5c4cd8d Compare April 17, 2024 07:00
@tomassebestik tomassebestik requested a review from kumekay April 17, 2024 07:05
Copy link
Collaborator

@kumekay kumekay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tomassebestik

New style looks good

@tomassebestik tomassebestik merged commit d6e200a into master Apr 22, 2024
17 checks passed
@tomassebestik tomassebestik deleted the fix/unicode-issues-windows branch April 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Response Awaiting a response from the author Status: Reviewing Issue is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants