Skip to content

Commit

Permalink
Wait at least max_report_interval_sec (project-chip#36771)
Browse files Browse the repository at this point in the history
  • Loading branch information
yufengwangca authored Dec 10, 2024
1 parent 9d3f291 commit c730701
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/python_testing/TC_MCORE_FS_1_2.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ async def test_TC_MCORE_FS_1_2(self):
nodeid=self.dut_node_id,
attributes=subscription_contents,
reportInterval=(min_report_interval_sec, max_report_interval_sec),
keepSubscriptions=False
keepSubscriptions=True
)

parts_list_queue = queue.Queue()
Expand Down
7 changes: 4 additions & 3 deletions src/python_testing/TC_MCORE_FS_1_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ async def test_TC_MCORE_FS_1_5(self):
nodeid=self.dut_node_id,
attributes=parts_list_subscription_contents,
reportInterval=(min_report_interval_sec, max_report_interval_sec),
keepSubscriptions=False
keepSubscriptions=True
)

parts_list_queue = queue.Queue()
Expand Down Expand Up @@ -249,14 +249,15 @@ async def test_TC_MCORE_FS_1_5(self):
await self.default_controller.CommissionOnNetwork(nodeId=self.th_server_local_nodeid, setupPinCode=passcode, filterType=ChipDeviceCtrl.DiscoveryFilterType.LONG_DISCRIMINATOR, filter=discriminator)

self.step(6)
max_report_interval_sec = 10
cadmin_subscription_contents = [
(newly_added_endpoint, Clusters.AdministratorCommissioning)
]
self._cadmin_subscription = await self.default_controller.ReadAttribute(
nodeid=self.dut_node_id,
attributes=cadmin_subscription_contents,
reportInterval=(min_report_interval_sec, max_report_interval_sec),
keepSubscriptions=False
keepSubscriptions=True
)

cadmin_queue = queue.Queue()
Expand All @@ -282,7 +283,7 @@ async def test_TC_MCORE_FS_1_5(self):
current_fabric_index, "AdminFabricIndex is unexpected")

self.step(10)
report_waiting_timeout_delay_sec = 10
report_waiting_timeout_delay_sec = max_report_interval_sec + 1
logging.info("Waiting for update to AdministratorCommissioning attributes.")
start_time = time.time()
elapsed = 0
Expand Down

0 comments on commit c730701

Please sign in to comment.