FanControl: modify percentSetting/percentSpeedSetting return value in…

… case NULL is written (match spec) (project-chip#36242) * Modified return value as per spec * Modified return value for speedSetting attribute * Updated test suite with return value.
espressif · Dec 3, 2024 · 9e85e85 · 9e85e85
1 parent 9a1d48c
commit 9e85e85
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/app/clusters/fan-control-server/fan-control-server.cpp b/src/app/clusters/fan-control-server/fan-control-server.cpp
@@ -212,7 +212,7 @@ MatterFanControlClusterServerPreAttributeChangedCallback(const ConcreteAttribute
                 }
                 else
                 {
-                    res = Status::WriteIgnored;
+                    res = Status::InvalidInState;
                 }
             }
             else
@@ -252,7 +252,7 @@ MatterFanControlClusterServerPreAttributeChangedCallback(const ConcreteAttribute
             }
             else
             {
-                res = Status::WriteIgnored;
+                res = Status::InvalidInState;
             }
         }
         else

diff --git a/src/app/tests/suites/TestFanControl.yaml b/src/app/tests/suites/TestFanControl.yaml
@@ -69,6 +69,8 @@ tests:
       attribute: "PercentSetting"
       arguments:
           value: null
+      response:
+          error: INVALID_IN_STATE
 
     - label: "Read back percent setting"
       command: "readAttribute"
@@ -105,6 +107,8 @@ tests:
       attribute: "SpeedSetting"
       arguments:
           value: null
+      response:
+          error: INVALID_IN_STATE
 
     - label: "Read back speed setting"
       command: "readAttribute"
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                     else
                     {
-                        res = Status::WriteIgnored;
+                        res = Status::InvalidInState;
                     }
                 }
                 else
@@ Expand Down Expand Up @@
                 }
                 else
                 {
-                    res = Status::WriteIgnored;
+                    res = Status::InvalidInState;
                 }
             }
             else
@@ Expand Down @@