Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(tests): Avoid the use of pull_request_target where possible #9899

Merged
merged 1 commit into from
Jun 24, 2024
Merged

ci(tests): Avoid the use of pull_request_target where possible #9899

merged 1 commit into from
Jun 24, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Remove the use of pull_request_target to avoid possible future security issues.
Also rename the tests workflow files to be more consistent.

Tests scenarios

Tested in my fork (lucasssvaz#22)

@lucasssvaz lucasssvaz self-assigned this Jun 19, 2024
@lucasssvaz lucasssvaz marked this pull request as draft June 19, 2024 03:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b4a1fbf

@lucasssvaz lucasssvaz marked this pull request as ready for review June 19, 2024 15:28
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jun 21, 2024
@me-no-dev me-no-dev merged commit 26db8cb into espressif:master Jun 24, 2024
31 checks passed
@lucasssvaz lucasssvaz deleted the ci/remove_target branch August 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasssvaz @me-no-dev @P-R-O-C-H-Y