Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdc): Disable SOF interrupt and CDC reset on begin() #9628

Merged
merged 12 commits into from
May 15, 2024
Merged

fix(cdc): Disable SOF interrupt and CDC reset on begin() #9628

merged 12 commits into from
May 15, 2024

Conversation

me-no-dev
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Small fixes for Debug prints on C3, C6 and H2":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(jtag/hwcdc): uses SOF detection from IDF":
    • body's lines must not be longer than 100 characters
  • the commit message "feat(jtag/hwcdc): uses SOF detection from IDF":
    • body's lines must not be longer than 100 characters
  • the commit message "feat: Moved SOF function":
    • summary looks too short
  • the commit message "feat: revert include ":
    • summary looks too short
  • the commit message "fix(usb): Fix log prints":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 12 commits (simplifying branch history).
⚠️ The Pull Request description is empty. Please provide a detailed description.

👋 Hello me-no-dev, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7bc1a5e

@SuGlider
feat(jtag/hwcdc): uses SOF detection from IDF
dea5be6 
Restores back IDF 5.1 SOF detection method in order to fix the HW CDC uploading process.

Enabling SOF mask in the ISR routine causes a problem with esptool uploading when using CDC/JTAG port.
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC3 milestone May 14, 2024
@SuGlider
feat(jtag/hwcdc): uses SOF detection from IDF
6b17247 
Restores back IDF 5.1 SOF detection method in order to fix the HW CDC uploading process.

Enabling SOF mask in the ISR routine causes a problem with esptool uploading when using CDC/JTAG port.
@SuGlider
feat: revert include
62dcd79 
This include is not necessary here.

Moving it back to the HWCDC.cpp file.
@SuGlider
feat: adding a necessary include
a67cd31 
Adding the IDF 5.1 SOF check include file.

Necessary to make it compile. Moved from HWCDC.h file to here.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7bc1a5e.

♻️ This comment has been updated with latest results.

@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +200.000.00000.000.00
ESP32S2💚 -16⚠️ +200.00⚠️ +0.01000.000.00
ESP32C30⚠️ +1040.00⚠️ +0.04000.000.00
ESP32C60⚠️ +1100.00⚠️ +0.05000.000.00
ESP32H20⚠️ +1120.00⚠️ +0.04000.000.00
ESP32💚 -16⚠️ +200.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
AsyncUDP/examples/AsyncUDPClient⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
AsyncUDP/examples/AsyncUDPMulticastServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
AsyncUDP/examples/AsyncUDPServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
BLE/examples/BLE5_extended_scan⚠️ +120--⚠️ +180⚠️ +180⚠️ +180--
BLE/examples/BLE5_multi_advertising⚠️ +120--⚠️ +180⚠️ +180⚠️ +180--
BLE/examples/BLE5_periodic_advertising⚠️ +120--⚠️ +180⚠️ +180⚠️ +180--
BLE/examples/BLE5_periodic_sync⚠️ +120--⚠️ +180⚠️ +180⚠️ +180--
BLE/examples/Beacon_Scanner⚠️ +120--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BLE/examples/Client00--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BLE/examples/EddystoneTLM_Beacon⚠️ +160--⚠️ +180⚠️ +180--⚠️ +120
BLE/examples/EddystoneURL_Beacon⚠️ +120--⚠️ +180⚠️ +180--⚠️ +120
BLE/examples/Notify⚠️ +200--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BLE/examples/Scan⚠️ +120--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BLE/examples/Server⚠️ +120--⚠️ +180⚠️ +180⚠️ +180⚠️ +160
BLE/examples/Server_multiconnect⚠️ +200--⚠️ +180⚠️ +180⚠️ +18000
BLE/examples/UART⚠️ +120--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BLE/examples/Write⚠️ +120--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BLE/examples/iBeacon⚠️ +160--⚠️ +180⚠️ +180⚠️ +180⚠️ +120
DNSServer/examples/CaptivePortal⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +200
EEPROM/examples/eeprom_class⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
EEPROM/examples/eeprom_extra⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
EEPROM/examples/eeprom_write⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogOut/LEDCFade⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogOut/LEDCSoftwareFade⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogOut/SigmaDelta⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogOut/ledcFrequency⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogOut/ledcWrite_RGB⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogRead⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/AnalogReadContinuous⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/ArduinoStackSize⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/CI/CIBoardsTest⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Camera/CameraWebServer⚠️ +120⚠️ +120------⚠️ +120
ESP32/examples/ChipID/GetChipID⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/DeepSleep/ExternalWakeUp⚠️ +120⚠️ +120------⚠️ +120
ESP32/examples/DeepSleep/TimerWakeUp⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESP32/examples/DeepSleep/TouchWakeUp⚠️ +120⚠️ +120------⚠️ +120
ESP32/examples/FreeRTOS/BasicMultiThreading⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/FreeRTOS/Mutex⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/FreeRTOS/Queue⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/FreeRTOS/Semaphore⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/GPIO/BlinkRGB⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/GPIO/FunctionalInterrupt⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/GPIO/FunctionalInterruptStruct⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/GPIO/GPIOInterrupt⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/HWCDC_Events⚠️ +120--⚠️ +1040⚠️ +1100⚠️ +1120--
ESP32/examples/MacAddress/GetMacAddress⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMTCallback⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMTLoopback⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMTReadXJT⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMTWriteNeoPixel⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMT_CPUFreq_Test⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMT_EndOfTransmissionState⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/RMT/RMT_LED_Blink⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/ResetReason/ResetReason⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/ResetReason/ResetReason2⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/BaudRateDetect_Demo⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/OnReceiveError_BREAK_Demo⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/OnReceive_Demo⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/RS485_Echo_Demo⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/RxFIFOFull_Demo⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/RxTimeout_Demo⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/Serial_All_CPU_Freqs⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/Serial_STD_Func_OnReceive⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Serial/onReceiveExample⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/TWAI/TWAIreceive⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/TWAI/TWAItransmit⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Template/ExampleTemplate⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Time/SimpleTime⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESP32/examples/Timer/RepeatTimer⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Timer/WatchdogTimer⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Touch/TouchButtonV2⚠️ +120⚠️ +120--------
ESP32/examples/Touch/TouchInterrupt⚠️ +120⚠️ +120------⚠️ +120
ESP32/examples/Touch/TouchRead⚠️ +120⚠️ +120------⚠️ +120
ESP32/examples/Utilities/HEXBuilder⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Utilities/MD5Builder⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP32/examples/Utilities/SHA1Builder⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP_I2S/examples/ES8388_loopback⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP_I2S/examples/Record_to_WAV⚠️ +120--------⚠️ +120
ESP_I2S/examples/Simple_tone⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
ESP_NOW/examples/ESP_NOW_Broadcast_Master⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESP_NOW/examples/ESP_NOW_Broadcast_Slave⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESP_NOW/examples/ESP_NOW_Network⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESP_NOW/examples/ESP_NOW_Serial⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESP_SR/examples/Basic⚠️ +120----------
ESPmDNS/examples/mDNS-SD_Extended⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
ESPmDNS/examples/mDNS_Web_Server⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
FFat/examples/FFat_Test⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
FFat/examples/FFat_time⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPClient/examples/Authorization⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPClient/examples/BasicHttpClient⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPClient/examples/BasicHttpsClient⚠️ +120⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
HTTPClient/examples/HTTPClientEnterprise⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPClient/examples/ReuseConnection⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPClient/examples/StreamHttpClient⚠️ +12000⚠️ +180⚠️ +180--⚠️ +120
HTTPUpdate/examples/httpUpdate⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPUpdate/examples/httpUpdateSPIFFS⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPUpdate/examples/httpUpdateSecure⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
HTTPUpdateServer/examples/WebUpdater⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Insights/examples/DiagnosticsSmokeTest⚠️ +120⚠️ +120⚠️ +180----⚠️ +120
Insights/examples/MinimalDiagnostics⚠️ +120⚠️ +120⚠️ +180----⚠️ +120
LittleFS/examples/LITTLEFS_test⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +160
LittleFS/examples/LITTLEFS_time⚠️ +120💚 -160⚠️ +180⚠️ +180--⚠️ +120
NetBIOS/examples/ESP_NBNST⚠️ +120⚠️ +40⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientInsecure⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientPSK⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientSecure⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientSecureEnterprise⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientShowPeerCredentials⚠️ +120⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse⚠️ +120⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
PPP/examples/PPP_Basic⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Preferences/examples/Prefs2Struct⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Preferences/examples/StartCounter⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
RainMaker/examples/RMakerCustom⚠️ +120⚠️ +120⚠️ +180----⚠️ +120
RainMaker/examples/RMakerCustomAirCooler⚠️ +16000⚠️ +180----⚠️ +120
RainMaker/examples/RMakerSonoffDualR3⚠️ +120⚠️ +120⚠️ +180----⚠️ +120
RainMaker/examples/RMakerSwitch⚠️ +120⚠️ +160⚠️ +180----⚠️ +120
SD/examples/SD_Test⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
SD/examples/SD_time⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
SD_MMC/examples/SDMMC_Test⚠️ +120--------⚠️ +120
SD_MMC/examples/SDMMC_time⚠️ +120--------⚠️ +120
SPI/examples/SPI_Multiple_Buses⚠️ +120⚠️ +120------⚠️ +120
SPIFFS/examples/SPIFFS_Test⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
SPIFFS/examples/SPIFFS_time⚠️ +160⚠️ +120⚠️ +180⚠️ +180--💚 -160
SimpleBLE/examples/SimpleBleDevice⚠️ +120----⚠️ +180⚠️ +18000
TFLiteMicro/examples/hello_world⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Ticker/examples/Blinker⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Ticker/examples/TickerBasic⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Ticker/examples/TickerParameter⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
USB/examples/CompositeDevice⚠️ +120⚠️ +120--------
USB/examples/ConsumerControl⚠️ +120⚠️ +120--------
USB/examples/CustomHIDDevice⚠️ +120⚠️ +120--------
USB/examples/FirmwareMSC⚠️ +120⚠️ +120--------
USB/examples/Gamepad⚠️ +120⚠️ +120--------
USB/examples/HIDVendor⚠️ +120⚠️ +120--------
USB/examples/Keyboard/KeyboardLogout⚠️ +120⚠️ +120--------
USB/examples/Keyboard/KeyboardMessage⚠️ +120⚠️ +120--------
USB/examples/Keyboard/KeyboardReprogram⚠️ +120⚠️ +120--------
USB/examples/Keyboard/KeyboardSerial⚠️ +120⚠️ +120--------
USB/examples/KeyboardAndMouseControl⚠️ +120⚠️ +120--------
USB/examples/MIDI/MidiController⚠️ +120⚠️ +120--------
USB/examples/MIDI/MidiInterface⚠️ +120⚠️ +120--------
USB/examples/MIDI/MidiMusicBox⚠️ +120⚠️ +120--------
USB/examples/MIDI/ReceiveMidi⚠️ +120⚠️ +120--------
USB/examples/Mouse/ButtonMouseControl⚠️ +120⚠️ +120--------
USB/examples/SystemControl⚠️ +120⚠️ +120--------
USB/examples/USBMSC⚠️ +120⚠️ +120--------
USB/examples/USBSerial⚠️ +120⚠️ +120--------
USB/examples/USBVendor⚠️ +120⚠️ +120--------
Update/examples/AWS_S3_OTA_Update⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Update/examples/HTTPS_OTA_Update⚠️ +160⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Update/examples/HTTP_Client_AES_OTA_Update⚠️ +120⚠️ +40⚠️ +180⚠️ +180--⚠️ +120
Update/examples/HTTP_Server_AES_OTA_Update⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Update/examples/OTAWebUpdater⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Update/examples/SD_Update⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
WebServer/examples/AdvancedWebServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/FSBrowser⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HelloServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HttpAdvancedAuth⚠️ +160⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HttpAuthCallback⚠️ +120⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HttpAuthCallbackInline⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HttpBasicAuth⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HttpBasicAuthSHA1⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/HttpBasicAuthSHA1orBearerToken⚠️ +12000⚠️ +180⚠️ +180--⚠️ +160
WebServer/examples/MultiHomedServers⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/PathArgServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/SDWebServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/SimpleAuthentification⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/UploadHugeFile⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/WebServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WebServer/examples/WebUpdate⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/FTM/FTM_Initiator⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/FTM/FTM_Responder⚠️ +120⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/SimpleWiFiServer⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WPS⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiAccessPoint⚠️ +120⚠️ +200⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiBlueToothSwitch⚠️ +120--⚠️ +180⚠️ +180--⚠️ +160
WiFi/examples/WiFiClient⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiClientBasic⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiClientConnect⚠️ +120⚠️ +200⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiClientEnterprise⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiClientEvents⚠️ +160⚠️ +120⚠️ +180⚠️ +180--⚠️ +200
WiFi/examples/WiFiClientStaticIP⚠️ +160⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiIPv6⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiMulti⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiMultiAdvanced⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiScan⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiScanAsync⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiScanDualAntenna⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiSmartConfig⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiTelnetToSerial⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
WiFi/examples/WiFiUDPClient⚠️ +120⚠️ +160⚠️ +180⚠️ +180--⚠️ +120
WiFiProv/examples/WiFiProv⚠️ +120⚠️ +120⚠️ +180⚠️ +180--⚠️ +120
Wire/examples/WireMaster⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Wire/examples/WireScan⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
Wire/examples/WireSlave⚠️ +120⚠️ +120⚠️ +180⚠️ +180⚠️ +180⚠️ +120
BluetoothSerial/examples/DiscoverConnect----------⚠️ +120
BluetoothSerial/examples/GetLocalMAC----------⚠️ +120
BluetoothSerial/examples/SerialToSerialBT----------⚠️ +120
BluetoothSerial/examples/SerialToSerialBTM----------⚠️ +120
BluetoothSerial/examples/SerialToSerialBT_Legacy----------⚠️ +120
BluetoothSerial/examples/SerialToSerialBT_SSP----------⚠️ +120
BluetoothSerial/examples/bt_classic_device_discovery----------⚠️ +120
BluetoothSerial/examples/bt_remove_paired_devices----------⚠️ +120
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code----------⚠️ +120
ESP32/examples/Touch/TouchButton----------⚠️ +120
Ethernet/examples/ETH_LAN8720----------⚠️ +120
Ethernet/examples/ETH_TLK110----------⚠️ +120

@Jason2866
Copy link
Collaborator

@me-no-dev Did a few tests with this version and Tasmota. Does work.
When merged no need to use a modified version anymore :-)

@Jason2866 Jason2866 mentioned this pull request May 15, 2024
Closed
1 task
@me-no-dev me-no-dev merged commit 6adeca4 into master May 15, 2024
136 checks passed
@me-no-dev me-no-dev deleted the bugfix/cdc_upload_and_terminal branch May 15, 2024 11:59
@lucasssvaz lucasssvaz mentioned this pull request May 15, 2024
Closed
1 task
@SuGlider SuGlider mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-RC3
Development

Successfully merging this pull request may close these issues.
4 participants
@me-no-dev @Jason2866 @SuGlider @VojtechBartoska