Fix hal-uart truncated tx/rx buffer size (uint16_t -> uint32_t) #9554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello Unbinilium, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
lucasssvaz
added
Area: Peripherals API
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SuGlider
added a commit
that referenced
this pull request
Apr 24, 2024
Changed header files to use the same IDF buffer limits. * this is a backport from PR #9554
SuGlider
added a commit
that referenced
this pull request
Apr 24, 2024
Uses the same IDF 32bits size for TX/RX buffers. Changed header files to use the same IDF buffer limits. * this is a backport from PR #9554
SuGlider
added a commit
that referenced
this pull request
Apr 24, 2024
Uses the same IDF 32bits size for TX/RX buffers. Changed header files to use the same IDF buffer limits. * this is a backport from PR #9554
|
This PR has been backported into 2.0.16 by #9561 |
lucasssvaz
approved these changes
Apr 24, 2024
P-R-O-C-H-Y
approved these changes
Apr 25, 2024
me-no-dev
pushed a commit
that referenced
this pull request
Apr 29, 2024
* feat (uart): uses the same IDF 32bits size for TX/RX buffers Uses the same IDF 32bits size for TX/RX buffers. Changed header files to use the same IDF buffer limits. * this is a backport from PR #9554 * feat (uart): change UART events logs to Verbose UART events like BREAK or errors are now Verbose instead of Warning Level. Backporting change from Issue #9551 * feat (uart): uses the same IDF 32bits size for TX/RX buffers. Uses the same IDF 32bits size for TX/RX buffers. Changed header files to use the same IDF buffer limits. * this is a backport from PR #9554 * feat (uart): keep overflow log as warning Keeps Overflow / Buffer Full log messages in Warning Level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changed the parameter types of
rx_buffer_sizeandtx_buffer_sizein the incoming parameters of theuartBeginfunction fromuint16_ttouint32_t, which solved 2 issues:Tests scenarios
Related links
The
uart_driver_installfunction accepts incoming tx / rx buffer size parameters of typeint: https://github.com/espressif/esp-idf/blob/636ff35b52f10e1a804a3760a5bd94e68f4b1b71/components/esp_driver_uart/include/driver/uart.h#L113