Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): Enforce that the pre-commit checks are run before merge #9525

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Apr 17, 2024

Description of Change

This PR makes a workflow that will monitor and post status of the pre-commit checks. Due to the scope and permissions differences it needs to be a new workflow.

With that we can add this status to the branch protection and enforce that the pre-commit hooks were run without failing the CI.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 53c5e8e

@lucasssvaz lucasssvaz force-pushed the ci/enforce branch 3 times, most recently from db08b6a to 2a7332c Compare April 17, 2024 12:17
@VojtechBartoska VojtechBartoska added the Status: In Progress Issue is in progress label Apr 17, 2024
@lucasssvaz lucasssvaz marked this pull request as draft April 17, 2024 12:31
@lucasssvaz lucasssvaz marked this pull request as ready for review April 17, 2024 15:50
@lucasssvaz lucasssvaz added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress Issue is in progress labels Apr 17, 2024
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Apr 17, 2024
@me-no-dev me-no-dev merged commit e33543c into espressif:master Apr 17, 2024
50 checks passed
@lucasssvaz lucasssvaz deleted the ci/enforce branch April 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants