Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ftm): Fix compilation warning #9508

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Apr 14, 2024

Description of Change

Fix compilation warning by setting missing parameter use_get_report_api to true (IDF default).
This field was recently added to ESP-IDF and now the new libs also have it.

@lucasssvaz lucasssvaz added Area: Libraries Issue is related to Library support. Area: WiFi Issue related to WiFi labels Apr 14, 2024
@lucasssvaz lucasssvaz self-assigned this Apr 14, 2024
Copy link
Contributor

github-actions bot commented Apr 14, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a4dd59a

@lucasssvaz lucasssvaz changed the title bugfix(ftm): Fix compilation warning fix(ftm): Fix compilation warning Apr 14, 2024
@me-no-dev me-no-dev merged commit 908ca9f into espressif:master Apr 15, 2024
40 checks passed
@lucasssvaz lucasssvaz deleted the bugfix/comp_warn branch April 15, 2024 16:42
P-R-O-C-H-Y pushed a commit to P-R-O-C-H-Y/arduino-esp32 that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Area: WiFi Issue related to WiFi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants