Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GeebkleMINI ESP32C3: add variable for support internal built in switch #9499

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

SooDragon
Copy link
Contributor

Description of Change

add variable for support internal built in switch
This update will help Arduino users to easy-access built-in switch

Tests scenarios

Tested with arduino ide Ver 2.3.2
switch input functions were tested

Related links

https://cafe.naver.com/geekbleofficial

fix: add variable for support internal built in switch
Copy link
Contributor

github-actions bot commented Apr 13, 2024

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SooDragon, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6cca46c

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SooDragon, does this SW_BUILTIN comes from somewhere? I was not able to find any other board or reference that this definition is ever used in any examples etc. Thanks

@SooDragon
Copy link
Contributor Author

Hi @SooDragon, does this SW_BUILTIN comes from somewhere? I was not able to find any other board or reference that this definition is ever used in any examples etc. Thanks

That is for this specific board
You can find board description below

https://github.com/SooDragon/GeekbleMini-ESP32C3

Thank you

#define LED_BUILTIN LED_BUILTIN // allow testing #ifdef LED_BUILTIN

static const uint8_t SW_BUILTIN = 9;
#define BUILTIN_SW SW_BUILTIN // backward compatibility
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any sketch that uses BUILTIN_SW ? This is used for LED due to being like this in the past

@VojtechBartoska VojtechBartoska changed the title fix: add variable for support internal built in switch fix GeebkleMINI ESP32C3: add variable for support internal built in switch Apr 17, 2024
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Apr 19, 2024
@me-no-dev me-no-dev merged commit 8e75498 into espressif:master Apr 19, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants