-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: Matched pin numbers in docs to numbers in variants files #9422
Conversation
👋 Hello lbernstone, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of Change
Matched pin numbers in doco to numbers in variants files. This should make it easier to use the examples as is. Also added entries for the new variants. Changed SD examples to make REASSIGN_PINS more transparent. Fixes #9082
Tests scenarios
Tested on esp32-c3.