-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes default 100ms delay with HWCDC write() is CDC is not connected #9307
Conversation
Fixes delay when CDC is disconnected. At this time is only fixes it when USB cable is unplugged.
fixes delay when CDC is not connected. It was only considering when the USB cable was not plugged.
Adds 2 new methods: - isPlugged() will return true when USB cable is plugged, false otherwise. - isConnected() will return true when USB CDC is connected to a application in the USB Host side and communication is stablished.
Fixes the example to use the new added APIs for checking if USB cable is plugged and for checking if CDC is connected.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
Improves the functionality of HW CDC (HW Serial) when CDC is not connected to the Host side. At this point it solves the delay issue only when it is not plugged to the USB port. But even when plugged and the host enumerates it, it still delays when CDC is not connected, causing some side effect.
This PR fixes it and also adds 2 new APIs:
Tests scenarios
Bad Output (from UART0):
Related links
#9043