Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new RMT function rmtSetEOT(pin, EOT_Level) in the pin remap macros #9266

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

This PR updates and adds the new RMT API bool rmtSetEOT(int pin, uint8_t EOT_Level); to the list of MACROS from io_pin_remap.h

It also include this new funtion to the Migration Guide documentation.

Tests scenarios

Just CI.

Related links

None

@SuGlider SuGlider added Type: Bug 🐛 All bugs 3.0 migration issue relates to migration from 2.X to 3.X version labels Feb 20, 2024
@SuGlider SuGlider added this to the 3.0.0-RC1 milestone Feb 20, 2024
@SuGlider SuGlider self-assigned this Feb 20, 2024
Copy link
Contributor

github-actions bot commented Feb 20, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fix: adds RMT new function to io_pin_remap list":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "Fix: adds rmtSetEOT(int pin, uint8_t EOT_Level) to the new API list":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "Fix: error in macro definition - left over from function signature":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "RMT_pin_remap_fix" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.
Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e00ac1d

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Feb 20, 2024
@me-no-dev me-no-dev merged commit 1847723 into master Feb 20, 2024
54 checks passed
@me-no-dev me-no-dev deleted the RMT_pin_remap_fix branch February 20, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 migration issue relates to migration from 2.X to 3.X version Status: Pending Merge Pull Request is ready to be merged Type: Bug 🐛 All bugs
Projects
Development

Successfully merging this pull request may close these issues.

3 participants