Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LED pin aliases to Arduino Nano ESP32 for portability #9089

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Add LED pin aliases to Arduino Nano ESP32 for portability #9089

merged 1 commit into from
Jan 16, 2024

Conversation

sebromero
Copy link
Contributor

Description of Change

This PR adds aliases to control the RGB led on the Arduino Nano ESP32 board. On other Arduino boards those pins are named LEDR, LEDG, LEDB. To improve portability amoung the Arduino boards the Arduino Nano ESP32 should support those names.

Tests scenarios

Tested on Arduino Nano ESP32

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat: Add pin aliases for RGB LED pins to ensure portability.":
    • summary should not end with a period (full stop)

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello sebromero, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3eb2b65

@sebromero
Copy link
Contributor Author

@pillo79 Looks good?

@pillo79
Copy link
Contributor

pillo79 commented Jan 10, 2024

@pillo79 Looks good?

Please move the new labels to the end of the file, close to the LED_BUILTIN entry: the current place would create differences when choosing pin remapping options.
Otherwise LGTM, nice compatiblity fix 👍

@sebromero
Copy link
Contributor Author

@pillo79 That makes sense 😅 Done.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Jan 11, 2024
@me-no-dev me-no-dev merged commit a114af0 into espressif:master Jan 16, 2024
42 checks passed
@sebromero sebromero deleted the pin-aliases branch January 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants