fix(adc): Always use default read resolution in __analogReadMilliVolts #9006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to obtain correct milliVolts value. Add new __analogReadRaw function and move code from __analogRead without mapResolution part to __analogReadRaw. Refactor __anlogRead to use analogReadRaw (and mapResolution). Refactor __analogReadMilliVolts to always use default read resolution when reading adc value, as expected input by esp_adc_cal_raw_to_voltage is in default resolution (means replacing all calls of __analogRead with __analogReadRaw).
|
@P-R-O-C-H-Y @me-no-dev |
|
Looks sound to me. @P-R-O-C-H-Y PTAL |
P-R-O-C-H-Y
approved these changes
Dec 15, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This shall avoid that a change of the resolution of analog readings leads to incorrect values when using the analogReadMilliVolts function, as this function always expects the resolution to be the default one. For more information see description in #8999.
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v2.0.14 with UM FeatherS2 (ESP32-S2) board with an analog sensor (Truebner SMT50).
Related links
Related to #8999.