Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add to Boards Test check if build.board is uppercase #8950

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[CI] Add to Boards Test check if build.board is uppercase #8950

merged 2 commits into from
Dec 5, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

Added automated check if boards_name.build.board is uppercase.

Tests scenarios

Tested locally

Related links

#7942

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 1, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as draft December 1, 2023 16:10
@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as ready for review December 1, 2023 16:11
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Dec 1, 2023
lucasssvaz
lucasssvaz approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider self-requested a review December 4, 2023 14:50
SuGlider
SuGlider approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice check!

@SuGlider
Copy link
Collaborator

SuGlider commented Dec 4, 2023

Will we change all board to upper case?

@SuGlider
Copy link
Collaborator

SuGlider commented Dec 4, 2023

I found a board with '-' symbol too
ttgo-t-oi-plus.build.board=TTGO-T-OI-PLUS_DEV

@P-R-O-C-H-Y
Copy link
Member Author

I found a board with '-' symbol too ttgo-t-oi-plus.build.board=TTGO-T-OI-PLUS_DEV

I see but almost all boards use only uppercase chars + numbers + _
I think we should just stick to it and don't allow any other symbols.

@P-R-O-C-H-Y
Copy link
Member Author

Will we change all board to upper case?

For keeping compatibility we will leave old boards as is and only check this for new incoming boards.
Probably will change only some Heltec boards which were causing some issue. Need to double check it first.

@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0-Aplha3 milestone Dec 5, 2023
@me-no-dev me-no-dev merged commit 374280c into espressif:master Dec 5, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Type: 3rd party Boards
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0-Aplha3
Development

Successfully merging this pull request may close these issues.
5 participants
@P-R-O-C-H-Y @SuGlider @lucasssvaz @me-no-dev @VojtechBartoska